I think the form just needs be updated on file type change, some uncompleted fields from previously selected types might be hanging around and causing the error.
Steps to Reproduce:
At a site, go to the HWM tab and edit a HWM
Scroll to bottom, expand the HWM File Information section
Click 'Add File' button and then select 'Photo' as the file type.
Then select 'Other' as the file type and complete all mandatory fields
Click 'Create File' and note that the error message pops up stating there are incomplete fields
I think the form just needs be updated on file type change, some uncompleted fields from previously selected types might be hanging around and causing the error.
Steps to Reproduce: