USGS-WiM / whispers

Wildlife Health Information Sharing Partnership event reporting system(WHISPers) v2
Other
2 stars 1 forks source link

reroute users after they create an event #1293

Closed JChipault closed 1 year ago

JChipault commented 1 year ago

Undesired Design or Confusing behavior Currently, after a user creates a new event and clicks "ok" on the popup that gives the event number (screenshot below) they are looped back to another create event page that is empty, and this makes some folks think they have to re-enter their event.

image

It gets extra confusing if you scroll down to the bottom and see the red warnings... some folks think "wait, I'm being told I got something wrong on the event I just entered" when really the warnings are because there's no data entered for a non-existent subsequent event.

If Possible, Describe a Solution Couple possibilities here and we're wondering what you think. Simple is ok. Maybe we just reroute users to the home page after they click "ok"? Then they'd just click "Create Event" again if they want to create another event. Maybe have that popup that currently has just the "ok" button ask the user if they want to return to the home page or enter a new event (or go to the event page for the event they just created?) and then have them click the option they want?

BlakeDraper commented 1 year ago

@JChipault for simplicity for now, I am redirecting the user to Home after completion. I like your idea of an array of choices in buttons, but that will require a bit more dedicated time. Implementation live on test server.

JChipault commented 1 year ago

Simple is good. However, I bumped in to an issue here (or maybe it's unrelated?). It's our old friend the JSON error message that tells you the event is not saved, so you click "Save event" button again and then it goes through fine... however, when you look at the home page map, you've got duplicate events (see 171095 and 171096). But then I tried it again and 171097 went without a hitch.

BlakeDraper commented 1 year ago

@JChipault That is unrelated. To address that, we'll need more info on what was being submitted. Seems like another case of a parsing error throwing back the error to the client while still proceeding with parsing and processing of the submission. CC @aaronstephenson for awareness.

JChipault commented 1 year ago

I tried entering the same event info and did not get the error again. I'll try to be better about getting more data about it if it happens again.

So #1293 is probably ready for live then whenever we next bundle a push to live

BlakeDraper commented 1 year ago

Done in v2.18.0.