search

USGS-WiM / whispers

Wildlife Health Information Sharing Partnership event reporting system(WHISPers) v2
Other
2 stars 1 forks source link

real-time notifications #900

Closed JChipault closed 4 years ago

JChipault commented 4 years ago

Here's a summary of what we're seeing with the real-time notifications in test 2.13.0. When I say "no alerts sent" I mean that we see no emails in inboxes nor do we see notifications within the application. We haven't tested the real-time notifications associated with setting up accounts yet. The rest fall into two categories. 1) No alerts sent: Request for new species, diagnosis, org collaboration request service request service request response service request response comments add collaborator

2) Error message (and no alerts sent): collaborator alert --> get this toast message after hit "issue alert": Error. Collaboration request response not submitted. Error message: SyntaxError: JSON.parse: unexpected character at line 1 column 1 of the JSON data. Blue loading bar at the bottom of the screen just goes on forever after toast message with error disappears. Nothing else happens.

high impact diagnosis --> get this toast message: Error. Species Diagnosis not created. Error message: SyntaxError: JSON.parse: unexpected character at line 1 column 1 of the JSON data However, it did add the data. No alerts sent.

quality check --> get this toast message when try to set process status to Quality Check Needed: Error. Event not updated. Error message: SyntaxError: JSON.parse: unexpected character at line 1 column 1 of the JSON data However, it does seem to save the process status (i.e., it's set to "Quality Check Needed" if I click back into that subform and look at it again). No alerts sent.

JChipault commented 4 years ago

re-check of notifications that produced error messages... collaborator alert --> same error high impact diagnosis --> same error quality check --> same error

JChipault commented 4 years ago

Request for new species, diagnosis, org --> working collaboration request --> working service request --> working service request response --> working, but sending in duplicate service request response comments --> working, but sending in duplicate add collaborator --> working

BlakeDraper commented 4 years ago

Do believe this is addressed on backend but will proceed with testing.

BlakeDraper commented 4 years ago

@JChipault our testing has indicated that these issues are resolved and real-time notifications are behaving as expected. Do you agree with that, or are you still experiencing these problems?

JChipault commented 4 years ago

collaborator alert --> working now. Few tweaks: 1) Can comment type be "collaborator alert"? (currently coming through as "other") 2) Can the [ ] and '' be removed from around the name on this part of the long-form of the message I received: Alert sent to: ['Jenny Chipault']. 3) can we get some of the language from the notifications table (pasted below) integrated into the interface under the comment box? Suggest: "Enter a comment to be saved to the event record. This comment will also be sent to the selected collaborators and overrides their WHISPers email notification settings to allow you to immediately email important communications. Please use thoughtfully." image 4) the sort arrow in the collaborators column doesn't seem to do anything. if it's easier to remove than to fix, that's fine. image

JChipault commented 4 years ago

high impact diagnosis --> working, but sending in duplicate image

... ah, maybe because I'm both the event owner AND on the whispers admin string??

yup, checked with Bryan and he only got one copy of this email.

I'm fine with this in duplicate because it won't happen much in real life

JChipault commented 4 years ago

quality check --> working

JChipault commented 4 years ago

service request response --> working, but sending in duplicate

probably because I'm both user who made the request and event owner?

This scenario will likely happen quite often... any chance we could prevent it from sending two of the same emails to the same person? However, sometimes the event owner and the write collaborator making a service request could be different people.

image

JChipault commented 4 years ago

service request response comments --> working, but getting a lot of emails (see https://github.com/USGS-WiM/whispersservices_django/issues/342).

BlakeDraper commented 4 years ago

Closing this issue because the issues mentioned have been distributed among other issues across the two repos.

BlakeDraper commented 4 years ago

@JChipault Let's move any future problem with realtime notifications into individual issues.