search

USGS-WiM / whispersservices

Django services for WHISPers
2 stars 1 forks source link

no emailed notifications for service response #553

Closed JChipault closed 2 years ago

JChipault commented 2 years ago

Describe the bug It appears that real-time emails are being sent for service request comments but not for service request responses. We've tested this on the test site and also asked folks using the production site if they are getting emailed notifications for service request response and they say they are not.

To Reproduce Steps to reproduce the behavior:

  1. From one user account put in a service request
  2. From a different user account with WHISPers admin privileges, select a response to that service request (note that this is separate from making a comment... there's a "Respond" button that presents a yes/no/maybe option)
  3. See if user account from step 1 gets an email
  4. Note that no email is sent; however user from step 1 does get a notification in their user dashboard.

Expected behavior Expect real-time service request response notification emailed out (in addition to being on user dashboard)

JChipault commented 2 years ago

I should add that it'd be the user who made the request and the event owner who would get the service request response email, as per our shared notifications spreadsheet. Often the person making the request and the event owner would be the same person, but not always.

aaronstephenson commented 2 years ago

Fixed in ffd2b06, will be included soon in next Test branch release.

JChipault commented 2 years ago

well, that was fast! Thanks

aaronstephenson commented 2 years ago

You betcha! I just happened to be working on an other issue and this was an easy fix 😄

JChipault commented 2 years ago

Emails seem to be sending now. @nbaertlein - when Aaron pushes these fixes to the live site, it might be good to let epis know that they'll be getting these notifications now.