search

USGS-WiM / whispersservices

Django services for WHISPers
2 stars 1 forks source link

Append "role_string" to the /auth response #568

Closed BlakeDraper closed 1 year ago

BlakeDraper commented 1 year ago

Now this probably actually means appending "role_string" to the user object since that appears to be what comes back from the auth endpoint success. The reason for doing this is to allow us to hide the roles table from the API. The client is using it in one superficial way which could be circumvented by this small tweak.

Let me know when done and I can update the client accordingly.

aaronstephenson commented 1 year ago

Hi Blake. When is this needed? I'm trying to finish a sprint on another project, so if this could wait until the middle of next week that would be fantastic.

BlakeDraper commented 1 year ago

@aaronstephenson sorry I missed your comment at the time. Obviously it has not been terribly urgent - but if you can do it in the next couple weeks (ideally before 2 weeks from today) that would be awesome.

aaronstephenson commented 1 year ago

The field is added. I made a pull request (#569) in case Lauren or you want to review it, but it's only three changed lines and I could just merge it into the dev branch at any time.

aaronstephenson commented 1 year ago

Lauren reviewed and approved the pull request.

aaronstephenson commented 1 year ago

Also removed the Role endpoint (#570, #571).

aaronstephenson commented 1 year ago

Merged into the Test branch in #572.

Deployed to the Test web server.