Fix compatibility with sunpy>=3.1

USNavalResearchLaboratory / eispac

Read the Docs

https://eispac.readthedocs.io/en/latest/

MIT License

23 stars 6 forks source link

Fix compatibility with sunpy>=3.1 #38

Closed wtbarnes closed 3 years ago

wtbarnes commented 3 years ago

Is there a reason to pin sunpy<3.1? Is there something in the latest release that breaks something in eispac?

MJWeberg commented 3 years ago

Yes, the tests were failing with ndcube v1.4.2 and sunpy v3.1 due to some underlying change in the plotting methods somewhere in the chain. I have not had a chance to fully diagnose the issue since I am still testing a workaround for the changes in NDCube v2.0, but I should hopefully have a patch ready later today or maybe tomorrow.

MJWeberg commented 3 years ago

Mostly fixed in NDCube patch (#40). There is still a warning that test_eismap expects to see that is not being issued in SunPy 3.1. For now, I just disabled the check for the warning, but kept the actual test case. Shall we consider this issue closed for now, or should we follow up on the missing warning first?

wtbarnes commented 3 years ago

I'll try to deal with that test in #39.