search

USNavalResearchLaboratory / eispac

Read the Docs
https://eispac.readthedocs.io/en/latest/
MIT License
23 stars 6 forks source link

Add `uncertainty_type` when loading data #55

Closed dstansby closed 2 months ago

dstansby commented 2 years ago

When I load some data, astropy prints a message that says

INFO: uncertainty should have attribute uncertainty_type. [astropy.nddata.nddata]

I'm guessing this is because when uncertainties are loaded the uncertainty_type (absolute or relative from memory) isn't specified. Would be good to specify this to remove this message!

MJWeberg commented 2 years ago

Hello @dstansby, thanks for trying out the code! We have been unsure what to do about the uncertainty type. The uncertainties given in the EIS observations are derived from the CCD read noise of EIS, which are technically neither the standard deviation nor the variance of the data (the only two types specified in astropy, last time I checked). In this case, would you recommend we create our own subclass of NDUncertanity or just use the stddev (since it at least has the correct units)?