USNavalResearchLaboratory / eispac

Read the Docs
https://eispac.readthedocs.io/en/latest/
MIT License
23 stars 6 forks source link

Address confusion in `ccd_offset.py` #57

Closed PaulJWright closed 2 years ago

PaulJWright commented 2 years ago

Would you please clarify/solve the comments/questions/confusions in ccd_offset.py as reproduced below.

https://github.com/USNavalResearchLaboratory/eispac/blob/571e19095dae6d8d4dded6f7e6566934469d8c4f/eispac/instr/ccd_offset.py#L56 https://github.com/USNavalResearchLaboratory/eispac/blob/571e19095dae6d8d4dded6f7e6566934469d8c4f/eispac/instr/ccd_offset.py#L58 https://github.com/USNavalResearchLaboratory/eispac/blob/571e19095dae6d8d4dded6f7e6566934469d8c4f/eispac/instr/ccd_offset.py#L63

RE Joss review: https://github.com/openjournals/joss-reviews/issues/4914