USNavalResearchLaboratory / eispac

Read the Docs
https://eispac.readthedocs.io/en/latest/
MIT License
23 stars 6 forks source link

Use units in `ccd_offset` function #97

Closed wtbarnes closed 4 months ago

wtbarnes commented 4 months ago

Cleans up the ccd_offset function to accept and output unitful quantities.

MJWeberg commented 4 months ago

Thanks, @wtbarnes! While I don't think users should ever need to access ccd_offset directly (nor am I sure if we should encourage the use of shift2wave, which is an old work around for using pixel indices), it never hurts to improve consistency and compatibility with Sunpy and Astropy.