USNavalResearchLaboratory / mgen

Multi-Generator (MGEN) traffic generation tool
https://www.nrl.navy.mil/itd/ncs/products/mgen
Other
83 stars 25 forks source link

Fixed invalid conversion from ‘char’ to ‘const char*’ in mgen.cpp #14

Closed jordanauge closed 2 years ago

jordanauge commented 4 years ago

Hi,

I suggesting this backfix to the tag v5.02c to fix the following compilation issue:

../src/common/mgen.cpp: In member function ‘MgenTransport* Mgen::FindTransportByInterface(const char*, UINT16, ProtoAddress::Type)’:
../src/common/mgen.cpp:435:57: error: invalid conversion from ‘char’ to ‘const char*’ [-fpermissive]
  435 |                             next->SetMulticastInterface('\0');
      |                                                         ^~~~
      |                                                         |
      |                                                         char
In file included from ../include/mgenFlow.h:5,
                 from ../include/mgen.h:5,
                 from ../src/common/mgen.cpp:3:
../include/mgenTransport.h:280:44: note:   initializing argument 1 of ‘virtual bool MgenUdpTransport::SetMulticastInterface(const char*)’
  280 |     bool SetMulticastInterface(const char* interfaceName);
      |                                ~~~~~~~~~~~~^~~~~~~~~~~~~
make: *** [Makefile.common:30: ../src/common/mgen.o] Error 1

Cheers, Jordan

bebopagogo commented 3 years ago

I'm not sure exactly how to go back and resolve all the conflicts that are coming up with this. I'd like to close this unless you know what I need to do that. I'm still not sufficiently well-versed in git to do figure out this ... at least via the Github web interface.

sskras commented 2 years ago

It seems this PR is still left open.

bebopagogo commented 2 years ago

I approved the change, but I haven't figured out how resolve the conflicts in this pull request that is on an old version of the code (the issue has been resolved in the current code) and accept the pull request. That's due to my limited experience with using Github and I haven't had time to dig into it. Any tips would be appreciated.

bebopagogo commented 2 years ago

OK - think I managed resolve it.