USNavalResearchLaboratory / nepc

NRL Evaluated Plasma Chemistry
Creative Commons Zero v1.0 Universal
13 stars 9 forks source link

nepc and nepc-test database on Windows WSL2 #62

Closed padamson closed 3 years ago

padamson commented 3 years ago

MySQL connector broken with python 3.8, so specify python==3.7 in nepc-dev conda env.

padamson commented 3 years ago

@littlewatkins do you see any issues with this PR now that you've gone through the instructions successfully?

littlewatkins commented 3 years ago

The only thing I did differently for the nepc_user_script.sql was use IDENTIFIED WITH mysql_native_password BY 'password'. I saw that on a forum about the differences between Mysql 5 and 8. If Grace used the current "method", then I guess that's not a big difference.

padamson commented 3 years ago

ok, as you can see I went ahead and merged. I think we need to do all of the configuration stuff in more elegant ways, perhaps having the end user put all required configuration items/secrets into a .env file and python-dotenv in a single "install" or "configuration" script. We could also look at creating a spack package.

littlewatkins commented 3 years ago

Yes, I'm definitely in favor or having a configuration item/directory or single script

For instance, I feel like I should have a place to store my nepc_user_script.sql within my nepc "home". So adding that to .gitignore or another spot would be good