search

USNavalResearchLaboratory / norm

NACK-Oriented Reliable Multicast (NORM) implementation & tools (RFCs 5740, 5401)
https://www.nrl.navy.mil/Our-Work/Areas-of-Research/Information-Technology/NCS/NORM/
Other
96 stars 33 forks source link

Adds basic CI #9

Closed mjvankampen closed 4 years ago

mjvankampen commented 4 years ago

Adds basic CI for:

MSVC static MSVC shared MingW static Linux static Apple static

One weird one is the MSVC shared, but windows has the declspec thingie going on so I believe it wise to do that build as well to see if we miss anything there. If you like I can add the others shared as well, but does not make too much sense to me.

bebopagogo commented 4 years ago

On the shared library MSVC build, it is failing due to something with the "win32PostProcess.cpp" file. I will look into that. However, the "post processing" source files should not be included in the NORM library. They are "helper" files for the "normApp" example that does not use the NORM API and should be included only when building the "normApp" example. Note the normApp example does not use the NORM API so it's not a good "example", but it is useful for performance testing comparison since it access the NORM C++ classes directly while the API has a separate thread ... The comparison is a useful test to make sure the threaded API code is working without significant impact on performance. So I have kept that maintained for that purpose.

I am going to remove the inclusion of the "post process" source files from the CMakeList build of the NORM library ... I will also see (with my very limited CMake experience) if I can change it so it is included when needed.

bebopagogo commented 4 years ago

FYI - I updated and pushed a CMakeLists.txt file that omits the "post process" files in the NORM library build. Now the CI for MSVC shared library is successful.