search

USNavalResearchLaboratory / protolib

Protean Protocol Prototyping Library
https://www.nrl.navy.mil/itd/ncs/products/protolib
Other
27 stars 20 forks source link

Not possible to build shared on windows #21

Closed mjvankampen closed 3 years ago

mjvankampen commented 4 years ago

There are no __declspec(dllexport) or __declspec(dllimport) statements.

bebopagogo commented 4 years ago

We haven't had a demand for that yet given the model of how we've used Protolib to date. If there is demand for that, it could be accommodated. Although, we haven't taken a lot of care in Protolib to clearly delineate "clean" public API interfaces to the classes ... I've made a little effort to do that in some cases, but have not been completely consistent in doing so. For example, there are some inconsistencies in method naming conventions among the Protolib classes I would clean up among other things

mjvankampen commented 4 years ago

I'll try https://cmake.org/cmake/help/latest/prop_tgt/WINDOWS_EXPORT_ALL_SYMBOLS.html#prop_tgt:WINDOWS_EXPORT_ALL_SYMBOLS to just export all. Maybe that's sufficient.

mjvankampen commented 3 years ago

As discussed in https://github.com/USNavalResearchLaboratory/norm/pull/15 protolib should be static.