search

USNavalResearchLaboratory / simdissdk

SIMDIS SDK
Other
114 stars 40 forks source link

Fix SIM-9586. #47

Closed gwaldron closed 5 years ago

gwaldron commented 5 years ago

Added a visitor to ModelCacheLoader that consolidates prep work for GLCORE/etal compatibility; added code to ensure that every geometry has a ColorArray so account for old FFP Material usage that was causing color state leakage when no ColorArray existed.

Also moved all the GLCORE code out of SetRenderBinsToInherit and consolidated them in the new visitor.

emminizer commented 5 years ago

This actually did not fix the problem with the model. But it gives me a place to start trying to debug to figure out why.

I like the reorg to a separate visitor, thanks.

Going to see if I can figure out why the solution is not working. If I can, I will merge this as-is then add to it.

gwaldron commented 5 years ago

Dan, I forgot to call traverse(node) at the end of the apply(Node) function...try that. [edit: typo]

emminizer commented 5 years ago

Yes that was it. Thanks!