Don't include Examples/Ocean if Triton is not found

USNavalResearchLaboratory / simdissdk

SIMDIS SDK

Other

114 stars 40 forks source link

Don't include Examples/Ocean if Triton is not found #52

Closed ChrisKwasneski closed 4 years ago

ChrisKwasneski commented 4 years ago

Check if Triton SDK was found before trying to include the Examples/Ocean sub project. Including Examples/Ocean errors out if included and TritonSDK is not available.

emminizer commented 4 years ago

https://github.com/USNavalResearchLaboratory/simdissdk/commit/e2a73383f00f0880f42c970201473204c852b407 should resolve this issue in a cleaner way that lets Ocean still build without Triton.

emminizer commented 4 years ago

Hi Chris, thanks for the PR. I think I got a solution pushed up that should fix your underlying problem. If this does not work for you, please let me know. Thanks!

ChrisKwasneski commented 4 years ago

Looks good and cleaner than my pr, I assumed Ocean reason was for the Triton SDK integration. Still wrapping my head around the internals of the SDK.

I'll pull latest and try to build.

ChrisKwasneski commented 4 years ago

Just wanted to drop a comment, this update did allow the build to proceed and complete without excluding Ocean.