search

USNavalResearchLaboratory / simdissdk

SIMDIS SDK
Other
114 stars 39 forks source link

Added recent Windows 10 SDK versions to cmake qt files #94

Closed glenn-saic closed 1 year ago

glenn-saic commented 1 year ago

Not sure if this can be better achieved with a wildcard.

Change also applies to same file in SMDIS plugin-api

emminizer commented 1 year ago

Thanks, this looks like a good change. I will try to get this merged in later today. I agree the definitions are tedious.

emminizer commented 1 year ago

Hi @glenn-saic -- I am looking at this again and having a hard time triggering an issue on my systems. I am considering removing this whole block that searches for glu32.lib and updates the CMAKE_PREFIX_PATH. Do you have a system where such a change would break your build?

Basically the entire if statement here would go away, from if(WIN32 AND on 51 to its endif() on 90.

glenn-saic commented 1 year ago

I commented out the section and cmake seemed to generate the plugin-api without issue. Should be fine.

Glenn

From: Daniel Emminizer @.> Sent: Monday, April 10, 2023 12:19 PM To: USNavalResearchLaboratory/simdissdk @.> Cc: Kinnear, Glenn T. [US] @.>; Mention @.> Subject: [EXTERNAL] Re: [USNavalResearchLaboratory/simdissdk] Added recent Windows 10 SDK versions to cmake qt files (PR #94)

EXTERNAL EMAIL -- This message originates from outside of SAIC

Hi @glenn-saic https://github.com/glenn-saic -- I am looking at this again and having a hard time triggering an issue on my systems. I am considering removing this whole block that searches for glu32.lib and updates the CMAKE_PREFIX_PATH. Do you have a system where such a change would break your build?

Basically the entire if statement here would go away, from if(WIN32 AND on 51 to its endif() on 90.

— Reply to this email directly, view it on GitHub https://github.com/USNavalResearchLaboratory/simdissdk/pull/94#issuecomment-1502019013 , or unsubscribe https://github.com/notifications/unsubscribe-auth/A52FBRWZD7CMKVEZ77G24ITXAQXGLANCNFSM6AAAAAAUYAUIOA . You are receiving this because you were mentioned. https://github.com/notifications/beacon/A52FBRQIC7CXMD7S4E3QQOTXAQXGLA5CNFSM6AAAAAAUYAUIOCWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTSZQ364K.gif Message ID: @. @.> >