Add my blog RSE feed to authors, improve feedparser relative link resolution & instructions

USRSE / blog

syndicated blog for research software engineer stories and experiences

https://usrse.github.io/blog/

1 stars 5 forks source link

Add my blog RSE feed to authors, improve feedparser relative link resolution & instructions #25

Closed rlskoeser closed 5 years ago

rlskoeser commented 5 years ago

Adds an author entry for posts from my personal site with tag RSE
Adds a dependency needed for feedparser to properly handle relative link resolution (caused a problem with images in my post)
Adds a note to the readme about installing python dependencies before running the script to generate posts when testing locally

vsoch commented 5 years ago

This looks great! Now you've peaked my curiosity and I want to test locally to reproduce your issue. And then I can install the dependency and confirm it looks good, and after merge we can watch it overnight to make sure everything is done as expected. Give me a few minutes to test!

vsoch commented 5 years ago

okay I think I've reproduced, images aren't properly handled:

Cleaning up, and installing the extra dependency:

rm -rf _posts/rsk/
pip install -r .circleci/requirements.txt
python script/generate_posts.py _data/authors.yml --output _posts/

boum! Beautifully done!

I found a similar issue here: https://github.com/kurtmckee/feedparser/issues/43

This LGTM.

rlskoeser commented 5 years ago

Thanks for the careful review. Yes, that's the issue that put me on the right track to solving the problem. I'll add a comment there with my solution.