search

USRSE / usrse-map

A map to show representation for the US-RSE Association
https://us-rse.org/usrse-map/
3 stars 1 forks source link

Adds a layer to display location-based groups #102

Closed rafmudaf closed 2 years ago

rafmudaf commented 2 years ago

This pull request adds a layer to the map to display RSE groups tied to a location (city or region) as described in https://github.com/USRSE/usrse.github.io/pull/876.

Screen Shot 2022-08-09 at 3 21 33 PM

cosden commented 2 years ago

@rafmudaf Looks great! I just pulled it down and previewed locally. It looks slick and I love that clicking on the regional group brings you straight to the slack channel. The colors and marker size all look great. Nice job! Sorry it took so long for me to get to it.

I'm been trying to think of any issues, and I have one potential concern that maybe we can brainstorm together as to how to resolve it. In presentations I often show the membership map to visually show "where our members are located" and the change over time. It would be great to have the ability to toggle the regional groups on and off to be consistent. Outside of that (which seems like a lot of work), should we just have a separate page that only insiders know where it is? Any other ideas?

danielskatz commented 2 years ago

maybe I shouldn't have merged the post PR without this one...

danielskatz commented 2 years ago

@cosden - I think we should merge this now, then address your issue above following that. If you agree, maybe go ahead and merge it

cosden commented 2 years ago

Yes, I agree. Let's merge. We can worry about this later. I'll open an issue to keep track of it. Honestly, it might only be me that cares about it, and I'm happy to have a page that isn't linked from anywhere that does this.

rafmudaf commented 2 years ago

@cosden I fully agree with your concern and I had also thought about this. It was just a perfect-vs-good situation. I'll think about some solutions to this, and feel free to assign me to #103 if its helpful.