search

USRSE / usrse.github.io

US RSE umbrella web page
https://us-rse.org
28 stars 83 forks source link

Pride Month - Sally Ride #1519

Closed lparsons closed 3 months ago

lparsons commented 3 months ago

Description

Added Pride Month Celebration Post for Sally Ride

Checklist:

When you are ready for a technical review/merge, post the for the link for the PR in the US-RSE Slack (#website) to ask for reviewers.

lparsons commented 3 months ago

@exoticDFT Could you review this PR? I had to rename the file to predate it or it wouldn't build. I also had to avoid linking the file in the main post or it wouldn't build. We can fix that up in a subsequent PR perhaps?

Preview link: https://output.circle-artifacts.com/output/job/90f2b199-8583-46aa-843c-ee662db40910/artifacts/0/usrse.github.io/2024-06-12-pride-spotlight-sally-ride/index.html

lparsons commented 3 months ago

I wasn't able to replicate the issue your having with the image, but I believe it's more of a "site-wide" issue, and thus I don't think it should hold up this post.

I was unable to create the link on the Pride Month post since that caused the entire Jekyl build to fail, claiming the page didn't exist. Happy to add that is a separate PR (or this one if someone knows how to do it).

image image

mrmundt commented 3 months ago

@lparsons - As long as you are linking it as a relative url (e.g., {{ site.baseurl }}/path/to/whatever ), Jekyll shouldn't complain.

lparsons commented 3 months ago

@lparsons - As long as you are linking it as a relative url (e.g., {{ site.baseurl }}/path/to/whatever ), Jekyll shouldn't complain.

Internal links typically use the post_url tag, which did not work for me.

exoticDFT commented 3 months ago

Interesting. I guess my phone's resolution is just slightly wider than yours. I do think it's a site-wide problem, so we can ignore that. If you're having issues with the internal post as well, let's just ignore that for later. I'll approve the PR so we can merge