search

USRSE / usrse.github.io

US RSE umbrella web page
https://us-rse.org
28 stars 82 forks source link

Redirect for subpages #186

Closed rafmudaf closed 4 years ago

rafmudaf commented 4 years ago

The redirect for the "April Meeting" page works for https://us-rse.org/2020-april-workshop/ but not for https://us-rse.org/2020-april-workshop/agenda/. Can a wild card be added to the redirect header:

 ---
 layout: page
 title: US-RSE Community Building Workshop
 permalink: /2020-april-workshop/*       <------ like this?
 redirect: https://us-rse.org/first-community-workshop
 ---

Or would this require all subpage-redirects to be listed individually?

github-actions[bot] commented 4 years ago

Welcome to us-rse! We are excited that this is your first issue!

vsoch commented 4 years ago

Hey @rafmudaf can you point me to where the subpage link is? We would need to add another permalink with redirect for it.

rafmudaf commented 4 years ago

Here's the page that goes to a 404 error: https://us-rse.org/2020-april-workshop/agenda/. I'll make a pull request for this and other pages.

rafmudaf commented 4 years ago

Can multiple permalink blocks exist in the same file? As in, can pages/redirects/2020-April-Workshop.md looks like this:

---
layout: page
title: US-RSE Community Building Workshop
permalink: /2020-april-workshop/
redirect: https://us-rse.org/first-community-workshop
subtitle: US-RSE Community Building Workshop
---

---
layout: page
title: US-RSE Community Building Workshop
permalink: /2020-april-workshop/agenda
redirect: https://us-rse.org/first-community-workshop/agenda
subtitle: US-RSE Community Building Workshop
---

---
layout: page
title: US-RSE Community Building Workshop
permalink: /2020-april-workshop/
redirect: https://us-rse.org/first-community-workshop
subtitle: US-RSE Community Building Workshop
---

---
layout: page
title: US-RSE Community Building Workshop
permalink: /2020-april-workshop/
redirect: https://us-rse.org/first-community-workshop
subtitle: US-RSE Community Building Workshop
---
vsoch commented 4 years ago

Thanks for the question! Each page is only allowed one section for front end matter, so unfortunately no, we'd need a separate page. Can you please link me to where the link for the agenda is currently present (and broken?)

rafmudaf commented 4 years ago

Here's where the agenda is currently presented: https://us-rse.org/first-community-workshop/agenda/ And here's where its broken: https://us-rse.org/2020-april-workshop/agenda/

vsoch commented 4 years ago

Sorry I'm not being clear - where is the link https://us-rse.org/2020-april-workshop/agenda/ being referenced, e.g., what other website has a link to https://us-rse.org/2020-april-workshop/agenda/ that results in 404?

vsoch commented 4 years ago

We are good to go ahead and PR, I just want to make sure that it's not something that can be fixed elsewhere! For example, if the link is from a usrse hosted site, we would much more easily fix it there. However if it's been distributed in a newsletter, we would best change it here.

vsoch commented 4 years ago

Anyway, better be safe than sorry, right? I've opened a PR to address this - https://github.com/USRSE/usrse.github.io/pull/187 the redirect works locally but we can check it when the artifacts are ready anyway.

rafmudaf commented 4 years ago

AAHH I'm sorry, I misunderstood. I got the link from an email and haven't seen it referenced anywhere on the US RSE website.

vsoch commented 4 years ago

Haha totally okay! Finding in an email is exactly the evidence I was looking for to warrant changing on here - we can't click "undo send" on emails sent months ago and fix those links (so we do it here!) :)

vsoch commented 4 years ago

Fixed with #187