USRSE / usrse.github.io

US RSE umbrella web page
https://us-rse.org
28 stars 83 forks source link

The Events page doesn't seem to show all events #667

Open lparsons opened 2 years ago

lparsons commented 2 years ago

The main ]events page](https://us-rse.org/events/) only shows the workshop in April right now, however, there are a number of other events that display on the calendar.

image image

vsoch commented 2 years ago

I suspect those are all repeated events, which is a design thing we added with the new site, and those just need to be added to the events layout page (which is largely the same as before but with a different design).

exoticDFT commented 2 years ago

I think this was a discussion before about the categories, but it's been a while so I might be misremembering. At the moment, it seems we are only listing a few available categories and dei is one. However, education (or something similar) is not. I think we talked about potentially just having a "working group" category, but decided on a single one for each instead? Either way, I may have to add in a new category for the education and training. I'll take a look.

@lparsons somewhat related, but not exactly, did you attempt to add the reoccurring DEI-WG meeting event? I was going to work on this today regardless, but didn't want to step on your toes if you already started to do so.

vsoch commented 2 years ago

@exoticDFT maybe we just need to add categories for each working group? I think it's fair to have separate (instead of clumping them into one).

exoticDFT commented 2 years ago

@vsoch Yep totally fine for me. I think that's what we had originally decided. Issue with all repeated events, at a first glance, seems to be that they are missing any category variable. I'll update and make sure everything is working

lparsons commented 2 years ago

@exoticDFT I have not yet attempted to add the recurring DEI-WG meeting, but thanks for asking. I was about to and ran into this and then got pulled into a few other things. If you've got bandwidth to work on it today, please do.

exoticDFT commented 2 years ago

We have a preference on what category to make of the Xpert reoccurring event. I'm not sure how I missed this first time around, but I'm not sure what the category should be.

Also I swear I had these reoccurring displaying the dates correctly, but that needs to be fixed as well.

vsoch commented 2 years ago

Maybe just conference, training, or something general?

exoticDFT commented 2 years ago

I'll go with training for now. If someone has a strong preference before we merge, I'll adjust it then.

exoticDFT commented 2 years ago

hmmm I found another bug. Any tag with a "-" in it will potentially be categorized as both things. For example, I just added

education-training:
    name: Education and Training
training:
    name: Training

to _data/events.yaml, updated Xpert to use training, updated the education recurring event to use education-training and now the recurring "Education and Training" event is under both the "Education and Training" and the Training category tags/sections, while the Xpert is only under "Training". I assume this has to do with the way we are parsing group_names, which I don't understand, but can be found in _includes/group-by-array.html

The same problem can be seen in the "virtual-workshops" and "workshops" categories. Anything with category virtual-workshop will end up in both tags/sections.

vsoch commented 2 years ago

@exoticDFT the script there is commented pretty robustly so I'd take a look to see what is going on. I suspect the issue is that we have category as a single item instead of a list, and then here:

{% if __element[include.field] contains name %}
      {% assign __item = __item | push: __element %}
    {% endif %}

That is seeing if the page at the include.field (which is category) contains the name, and this is done likely because it was assumed to be a list and not a text field. This explains the partial match. So perhaps there try testing for exact equality.

vsoch commented 2 years ago

Just to follow up here (chatting with @exoticDFT after this in slack) and the fix above indeed does work! :partying_face:

kescobo commented 1 year ago

Was this fix implemented (that is, can I close this issue?)