USRSE / usrse.github.io

US RSE umbrella web page
https://us-rse.org
28 stars 83 forks source link

Issue with CircleCI previews #945

Open exoticDFT opened 1 year ago

exoticDFT commented 1 year ago
    > The idea looks good. The links don't work in the preview, but my guess is this is an issue with the preview rather than the site.

I've been noticing this on the last couple of PRs I've made as well.

I think this is partially an issue either with CircleCI itself or the way we have it setup. The artifacts site doesn't seem to be able to handle the URL paths we expect. For example, we expect people to be able to go to https://us-rse.org/events/2022/2022-12-AGM/, but CircleCI seems to need us to add index.html to the end of the link. Oddly, this doesn't seem to always work though. E.g. at least two of the links on the US-RSE landing page don't work after adding the index.html (and fixing the other issue I mention below.)

Also, we may have a problem with the way we use "baseurl" (maybe?), at least in terms of CircleCI. I've noticed just about every link you click on in CircleCI artifacts adds an extra "https://output.circle-artifacts.com/" to the front of the URL, e.g. https://output.circle-artifacts.com/https://output.circle-artifacts.com/output/job/69a12ffd-95a9-4823-9007-26c8df8751a3/artifacts/0/usrse.github.io/working-groups. But if you drop the additional https bit and add index.html, the link works...https://output.circle-artifacts.com/output/job/69a12ffd-95a9-4823-9007-26c8df8751a3/artifacts/0/usrse.github.io/working-groups/index.html.

So with this and the index.html expectation, no links work in the preview correctly. You have to go back to the overarching artifacts page and find the page you want to view.

Originally posted by @exoticDFT in https://github.com/USRSE/usrse.github.io/issues/942#issuecomment-1271823979

crd477 commented 1 year ago

With respect to the first issue, it seems unlikely that CircleCI is interested in doing anything to address it. See: https://discuss.circleci.com/t/static-websites-in-artifacts/37093 which references: https://discuss.circleci.com/t/circle-artifacts-com-not-using-index-html/320