search

USST-RADSAT-SK / software-and-command

Code and Documentation for USST’s RADSAT-SK in their first Canadian CubeSat Project
8 stars 0 forks source link

Operation/initial communication design #168

Closed matthew-buglass closed 2 years ago

matthew-buglass commented 2 years ago

Merge for the Communication tasks and the abstraction of the transceiver API

Close #149 Close #148 Close #108 Close #30

ChrisAmaya commented 2 years ago

Initial build looks good but there is an warning saying "/operation/crypt/tiny-aes/pkcs7Padding.c:44:19: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]" If we are using an XOR encryption, I think this branch should remove the aes folder as we are not using it anymore.

tyrelkostyk commented 2 years ago

@ChrisAmaya re: your comment on removing the AES library

I have anoter branch in progress right now (operation/initial-message-implementation) that is taking care of removing the old encryption software, and adding in the new XOR Cipher implementation. So it'll get taken care of in that branch once the PR comes in (hopefully within this next week here)

ChrisAmaya commented 2 years ago

@ChrisAmaya re: your comment on removing the AES library

I have anoter branch in progress right now (operation/initial-message-implementation) that is taking care of removing the old encryption software, and adding in the new XOR Cipher implementation. So it'll get taken care of in that branch once the PR comes in (hopefully within this next week here)

Okay sounds good, thanks for the clarity