search

USStateDept / State-TalentMAP

A comprehensive research, bidding, and matching system to match Foreign Service employees with the right skills to available posts and positions. API Layer - https://github.com/USStateDept/State-TalentMAP-API
Other
32 stars 17 forks source link

Determine use of query-string vs node.js query string #410

Open mjoyce91 opened 7 years ago

mjoyce91 commented 7 years ago

Determine whether to use query-string or node.js querystring and change front-end if needed.

mjoyce91 commented 7 years ago

Use of querystring is fine, but getting the following error in tests:

Summary of all failing tests
 FAIL  src/Components/Filters/Filters.test.jsx (7.037s)
  ● FiltersComponent › can call the createQueryString function to create multi-parameter query strings

    Timeout - Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL.

      at pTimeout (node_modules/jest-jasmine2/build/queueRunner.js:53:21)
      at Timeout.callback [as _onTimeout] (node_modules/jsdom/lib/jsdom/browser/Window.js:523:19)
      at ontimeout (timers.js:365:14)
      at tryOnTimeout (timers.js:237:5)
      at Timer.listOnTimeout (timers.js:207:5)
jseppi commented 7 years ago

If it's causing issues, I wouldn't spend too much time on it. The lib you're using already is also well tested and used by lots of projects.