Try to eliminate the need of patching `golang.org/x/crypto/ssh`

USTC-vlab / sshmux

A new, simple implementation of SSH reverse proxy for Vlab

3 stars 1 forks source link

Try to eliminate the need of patching `golang.org/x/crypto/ssh` #17

Open stevapple opened 1 month ago

stevapple commented 1 month ago

It would be great if we don't vendor a modified copy of the library. It's a perfect time now to check which API we need doesn't exist now, and try to get them into the new golang.org/x/crypto/ssh/v2 package.

stevapple commented 1 month ago

@iBug https://github.com/USTC-vlab/sshmux/commit/42b20754147cb6d9264d92c005b765fedb269593 is the only patch to existing x/crypto/ssh codebase, can you elaborate on the context? I didn't find a related issue in https://github.com/golang/go

iBug commented 1 month ago

The context is loosely in the commit message. For Ubuntu 22.04 and lower, the packaged openssh-server doesn't implement the new "ping" protocol, and would exit immediately upon receiving one (unknown packet type 192). We found it easier to disable this optional feature altogether in that patch.