search

USThing / Issues

Public repo for tracing the USThing iOS, Android and Server private repo.
9 stars 2 forks source link

Server error in Grade for year one #316

Closed frankwangyufei closed 5 years ago

frankwangyufei commented 5 years ago

Expected behavior

Show grade if available, or disable grade option if sis is not available

Actual behavior

a generic "server error" toast shows if sis not available (for year 1 with no grades)

Steps to reproduce

login as year one, press "grade" tab

Environment

elise-ng commented 5 years ago

@unknown31415927 it should show current enrolled courses with n/a as grade, what's the error message?

frankwangyufei commented 5 years ago

I forgot. I think it has something to do with sis grade not being accessable for those with no prior grades. May need a year one account to test :thinking:

elise-ng commented 5 years ago

seems year 1 students don't see "change term" button on sis during their first semester, which breaks our current code

this should be a server side issue

elise-ng commented 5 years ago

fix deployed, will show grades of latest semester only if that error occurs, asking affected user to verify the fix

elise-ng commented 5 years ago

fix verified by user, closing issue