Feature/web app organization

USU-Robosub / Poseidon

USU's third-generation autonomous submarine

http://usub.cs.usu.edu

17 stars 0 forks source link

Feature/web app organization #216

Open TekuConcept opened 7 years ago

TekuConcept commented 7 years ago

Routes are now in their own file, reducing index.js file size and perceived complexity.
Hardware specific calls have been moved to their own file. Route calls to hardware are made through a messenger.
Hardware initialization and management are now hidden behind an app module. This module exposes the already-created factories to AI scripts.
Removed experimental snippets, such as task-script implementations, in favor of promoting more organized approaches of execution and testing.

kylerjensen commented 7 years ago

I think a second review on this PR would be good just because it's so large @nfcopier

nfcopier commented 7 years ago

I'm pretty sure this pull request inherits changes from a couple of the previous PRs. I completed a review of #212. Check that one for my requested changes.

nfcopier commented 7 years ago

I really like most of these changes. Awesome job. 👍 Just got a couple tweaks for ya. I also think it would be a good idea for us to talk about dependency injection, encapsulation, and component decoupling/cohesion in person sometime.

TekuConcept commented 7 years ago

I finished reading the "Design Patterns" book cover to cover as well as "The Clean Coder" and I am in the middle of the book "Clean Code." I feel I have a better idea now about writing amazing clean code.