search

UStAEnts / x32-reflector

A simple module that polls x32 to send all parameter changes and then redirects them to a set of configured clients
0 stars 0 forks source link

(release/v1.1.1): code cleanup #9

Open Vitineth opened 2 years ago

Vitineth commented 2 years ago

This change shouldn't have much of an impact on the functionality of the system, in general it has just divided the code up to extract out the HTTP server into a more modular structure and changed slightly how the interactions work (ie x32 devices are now identified by name rather than ip/port combinations in the web requests). To accomplish this, one technically breaking change has had to be made in which the name key of the x32 devices in the config is now required and constrained to alphanumeric with -_. This makes it simpler when using it in the web requests and as they are now identified by name, these names must be unique. This is marked as a patch change as this will not affect the existing configurations in use.

Addresses #6

wlabarron commented 2 years ago

I've not looked at the code in great detail but my feedback points are:

Vitineth commented 1 year ago

New updates have been released and this has been deployed on the pi

@wlabarron - version has been changed, you might have better luck with npm run dev now, let me know if it still does not work

wlabarron commented 1 year ago

Can confirm that npm run dev worked correctly on my local machine. #10 also looked fixed on my machine, haven't tested with a real desk yet but seems good otherwise.

Vitineth commented 1 year ago

@wlabarron astounded you don't just have an x32 lying around on your desk to use! As soon as we've got a run on a real desk this will get merged in to make main match the version deployed to the pi