Closed mathematicalmichael closed 4 years ago
Merging #391 into v3-dev will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## v3-dev #391 +/- ##
=======================================
Coverage 78.18% 78.18%
=======================================
Files 23 23
Lines 4263 4263
=======================================
Hits 3333 3333
Misses 930 930
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 03e52c0...c3c24dd. Read the comment docs.
@smattis this is now reproducing the behavior that my dockerfile encountered in my recent comments for #382, I wanted there to be a place with complete build logs you could use to help sanity-check what I said.
wouldn't mind keeping this open until the other branch is merged, then will close it out. It'll be helpful to have around for a second-source of debugging but I think the redundancy is unwarranted in the CI pipeline. I wouldn't mind building a CI pipeline to check + push a docker image that contains the full dependencies to run every example so we can have a really ephemeral quickstart point with a docker run command. That would effectively catch any of the same problems, and have latest ubuntu as a base image to keep up with upstream(ish) changes to libraries.
figured it couldn't hurt to get a second CI provider's opinion.