Enforce step_delta consistency

UT-Covid / episimlab

Framework for development of epidemiological models

https://ut-covid.github.io/episimlab/

BSD 3-Clause "New" or "Revised" License

3 stars 1 forks source link

Enforce step_delta consistency #31

Open kellypierce opened 3 years ago

kellypierce commented 3 years ago

The number of intervals per day (step_delta) is hard-coded in partition.py and may therefore be inconsistent with user specification of this interval in a model run:

https://github.com/eho-tacc/episimlab/blob/8b0b66b8ce866b21650ac1f4e018d6a34e4a2ead/episimlab/partition/partition.py#L127

Refactor to use utils/datetime.py to set a datetime interval. Remove assertion in seir/base.py that works around this hard-coding bug by asserting step_delta is one day.

kellypierce commented 3 years ago

step_delta is not surfaced in the CLI, but it is set by CLI-dependent helper functions (with the current workflow being to create a new CLI script for each use case).

https://github.com/eho-tacc/episimlab/blob/eeb2cea5273367ef49a015d6c1a905d467e07609/scripts/DemoATX.py#L49