UT-Covid / episimlab

Framework for development of epidemiological models
https://ut-covid.github.io/episimlab/
BSD 3-Clause "New" or "Revised" License
3 stars 1 forks source link

Simply math in SEIR models #35

Closed kellypierce closed 2 years ago

kellypierce commented 3 years ago

https://github.com/eho-tacc/episimlab/blob/b409c88b262cd91783cd35ecc0d6fb14623ac891/episimlab/seir/bf_cython_engine.pyx#L231

If new_S = S + d_S and compt_v[n, a, r, 0] = new_S - S, then compt_v[n, a, r, 0] = d_S

Other compartment deltas can be similarly revised. This wouldn't make a dramatic impact on performance, but it would clean up the code a bit.

kellypierce commented 3 years ago

partially addressed in https://github.com/eho-tacc/episimlab/pull/38

ethho commented 2 years ago

Fixed in v2