UT-Covid / episimlab

Framework for development of epidemiological models
https://ut-covid.github.io/episimlab/
BSD 3-Clause "New" or "Revised" License
3 stars 1 forks source link

Add demo vaccine model #44

Closed ethho closed 2 years ago

ethho commented 2 years ago
ethho commented 2 years ago

Note that stochastic_draw draws from Poisson distribution currently.

https://github.com/eho-tacc/episimlab/blob/e74c298f964d015fde4813ceac6666a68cf97af3/episimlab/compt_model.py#L126

@kellypierce I know we've had some discussion about this; we could write a binomial method similar to poisson:

https://github.com/eho-tacc/episimlab/blob/e74c298f964d015fde4813ceac6666a68cf97af3/episimlab/compt_model.py#L143-L155

kellypierce commented 2 years ago

Note that stochastic_draw draws from Poisson distribution currently.

https://github.com/eho-tacc/episimlab/blob/e74c298f964d015fde4813ceac6666a68cf97af3/episimlab/compt_model.py#L126

@kellypierce I know we've had some discussion about this; we could write a binomial method similar to poisson:

https://github.com/eho-tacc/episimlab/blob/e74c298f964d015fde4813ceac6666a68cf97af3/episimlab/compt_model.py#L143-L155

@eho-tacc I agree a binomial method would be good (as some people may have a preference). I think a process like SetupSampler might be the way to go. It's not strictly necessary for this PR though, so I'll put some thoughts in an issue so we can work on it later if we choose.