Minor script fixes - Githubissues

s-winter commented 5 years ago

When running an interactive shell for the idflakies user in a docker container created with iDFlakies, JAVA_HOME points to an invalid path in the container. The reason this did not affect the automated execution is that the environment is inherited from the root user when running scripts via "su - idflakies -c" and that .bashrc is not loaded for non-interactive shells (see first guard in .bashrc). To observe the issue, start an interactive shell for the idflakies user in any docker container created by the scripts and try to run maven.

The pull request sets JAVA_HOME to the same value as for the root user's environment in order to make it work for interactive sessions (e.g., for debugging).
As I consider it unlikely that the 'non-interactive guard' will ever be dropped from .bashrc, the pull request also removes the ineffective source instruction from run_project.sh.

august782 commented 5 years ago

I'm fine with merging this one. If there is nothing else from Wing, I would say merge it.

winglam commented 5 years ago

LGTM! Merging then.

UT-SE-Research / iDFlakies

Minor script fixes #6