search

UTA-FabLab / fabapp

Operational Software for any fablab or makerspace
Other
19 stars 21 forks source link

Pickup total fail tickets do not remove from storage #42

Closed MPZinke closed 4 years ago

MPZinke commented 4 years ago

If a ticket is put into storage, then picked up and marked as total fail, it does not remove the object from storage.
This is overlooked because all other ticket statuses proceed to ~/pages/pay.php where it is removed. This can be fixed by adding a removal call in the if statement https://github.com/UTA-FabLab/fabapp/blob/bd1b5eed5575a92f922e72b25172f9bced09c76e/pages/pickup.php#L65

FabosaurusRex commented 4 years ago

@MickPoletti , you broke the UI. Fix please.

MPZinke commented 4 years ago

Additional pickup process issue found while looking into this. There is a foreach statement here that causes the materials for each device to echo the "additional device" device option.

MPZinke commented 4 years ago

~/pages/pickup.php now removes object from storage_box if ticket is marked as total fail. This is because the object will be thrown in the trash or recycling.

MickPoletti commented 4 years ago

I removed the foreach statement that Mathew pointed out and it seems to have fixed the UI issue.

FabosaurusRex commented 4 years ago

UI issue appears to be fixed.

Tested out object removal - objects are still remaining in storage when ticket is ended as a Total Failure.

MPZinke commented 4 years ago

Bug fixed and ready for testing. Added correct variable name to fix issue.

FabosaurusRex commented 4 years ago

Passes tests in Dev branch on dev server.

FabosaurusRex commented 4 years ago

At some point Friday, the Information page stopped working and is now either calling incorrect index values and/or calling something that doesn't exist. This is top priority to get it working again and figure out what happened.

FabosaurusRex commented 4 years ago

Issue was fixed, has been tested, and is currently rolled in to Production branch. Closing.