UTA-FabLab / fabapp

Operational Software for any fablab or makerspace
Other
19 stars 21 forks source link

Feature Modification - Enable secondary email alert when wait queue tickets are removed #52

Closed FabosaurusRex closed 4 years ago

FabosaurusRex commented 4 years ago

FL staff has requested that when a manual wait queue ticket removal is performed, the removal message be sent to a mailing list/etc to help ensure clearer and more consistent communication and comm. history.

General idea is to add an editable site variable, then when manual removal is triggered evaluate whether site variable contains a value or not. If value exists, send copy of removal message to it, otherwise skip sending second mail.

FabosaurusRex commented 4 years ago

Wrote/committed initial version, will get verification and do testing Monday.

FabosaurusRex commented 4 years ago

Initial version was not pulling the logged-in-user's ID properly, fixed w/Mathew's help and corrected logic errors as well.

Passed initial Dev server testing.

Need to do some more exhaustive testing w/mailing list addresses/etc to verify site variable input isn't bugged.

FabosaurusRex commented 4 years ago

Tested out addresses containing hyphens, periods, and underlines, passed tests. Approving to merge in.

FabosaurusRex commented 4 years ago

Feature has passed on Test and in real-world usage, closing issue and deleting branch.