search

UTA-FabLab / fabapp

Operational Software for any fablab or makerspace
Other
19 stars 21 forks source link

Alter GateKeeper criteria to mirror workflow needs #67

Closed FabosaurusRex closed 3 years ago

FabosaurusRex commented 4 years ago

The realities of running the flipped model are showing that the current standards in GateKeeper are causing problems and need adjustment.

The criteria of "does the ID have items in storage waiting for pickup|are any items in storage there longer than MaxLength" is going to be altered to only evaluate whether any items in storage belonging to a specific ID have been there longer than MaxLength.

The criteria of "Does this ID owe us more than $0" is going to be changed to "Does this ID owe us more than $10", though we will make that amount a site variable to make altering it as necessary easier and not require Glenn to upload new code.

FabosaurusRex commented 4 years ago

Wrote+committed initial changes, will test on saturday when i'm testing out the printTicket changes.

FabosaurusRex commented 4 years ago

Gatekeeper now accurately recognizes if the ticket limit has been hit and lists out all tickets waiting for pickup/still open.

It kind of recognizes whether an item has been there longer than the maximum "keep in storage" time allowed - i had two set up to be more than 2 weeks and it recognized the second one initially, then did not recognize the first one after i closed the second one.

Amount of tickets is prioritized over length of stay, for some reason. Haven't looked into it yet.

FabosaurusRex commented 4 years ago

Resolved issues with index being off on storage-time-based ticket denial criteria. Passed initial testing, merging into Dev branch.

FabosaurusRex commented 3 years ago

Fix has been rolled out to production. Closing issue.