Closed nl32 closed 8 months ago
vercel[bot]
commented
10 months ago The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| jupiter | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Feb 16, 2024 11:17pm |
nl32
commented
8 months ago Looks good but some text looks a little to large on smaller screens I made a lot of text everywhere bigger, let me know if you see any other pain points.
Jake3231
commented
8 months ago @RubenOlano @nl32 What is the expected usability for this PR? "Usable" vs "Polished"? Overall looks great, but there's a fee places that need work but are certainly usable right now.
nl32
commented
8 months ago What is the expected usability for this PR? "Usable" vs "Polished"? Overall looks great, but there's a fee places that need work but are certainly usable right now.
The goal was largely to get rid overflow issues on smaller screens, improve readability on smaller screen sizes, and that core features like the directory, events, settings, and all their functionality can be used on mobile, Which I think this pr addresses. The main areas that I see as having issues are the carrousel, club page header, and events page, which each are being addressed in their own tickets.
@Jake3231 if you see anything else you think needs adjustment or polishing I'd love to hear it.
RubenOlano
commented
8 months ago Only thing I got is the login button stuff not being centered, other than that I'm happy
Jake3231
commented
8 months ago What is the expected usability for this PR? "Usable" vs "Polished"? Overall looks great, but there's a fee places that need work but are certainly usable right now.
The goal was largely to get rid overflow issues on smaller screens, improve readability on smaller screen sizes, and that core features like the directory, events, settings, and all their functionality can be used on mobile, Which I think this pr addresses. The main areas that I see as having issues are the carrousel, club page header, and events page, which each are being addressed in their own tickets.
@Jake3231 if you see anything else you think needs adjustment or polishing I'd love to hear it.
The biggest thing is the club page on mobile. If that's a known issue that's being addressed elsewhere, it looks good to me!
This pr adds tweaks to the layout and styling at different breakpoints to make it more usable on smaller screens and phones. this makes most of the core features more usable on mobile, however a lot of it doesn't look perfect 🫣, so comments are greatly appreciated. One large issue is that the directory grid height shifts whenever new orgs load in.