search

UTDNebula / jupiter

A tool to help students get involved on campus
https://jupiter.utdnebula.com
MIT License
14 stars 6 forks source link

JUP-52-make-carousel-bigger #216

Closed ishaanthenerd closed 8 months ago

vercel[bot] commented 8 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jupiter ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2024 2:03am
RubenOlano commented 8 months ago

Actually, it seems like the branch is behind develop, fix that and we can merge it in

nl32 commented 8 months ago

I mean it looks good but I can't tell a difference between this pr and dev. I feel like there was some design specific change that was wanted but I don't remember what exactly.

nl32 commented 8 months ago

I think it was that Solomon wanted the carousel to fill the whole space horizontally, cause currently if you widen the page enough there is additional white space, @RubenOlano correct me if I'm wrong.

ishaanthenerd commented 8 months ago

Yep, that's what Solomon told me.

nl32 commented 8 months ago

I reverted the nextjs change because it broke some other stuff.