search

UTDNebula / skedge

MIT License
8 stars 7 forks source link

Feat/prof page #13

Closed heartgg closed 1 year ago

heartgg commented 1 year ago

Related to #6 More description soon

heartgg commented 1 year ago

@LudoLogical Thank you very much for spending the time to review the PR. I greatly appreciate it! I addressed most of the issues, but I left some that I thought would be solved in the future via code prettiness plugins, linting, etc. I took note of them and will start working on getting those plugins into the codebase and required before merging PRs (via CI/CD). I also left Tailwind styling as is (even though sometimes it's repetitive) per the Tailwind documentation.

LudoLogical commented 1 year ago

@heartgg You're very welcome; thank you for considering the review! It's great that you're working on setting up things like eslint and prettier. Leaving the Tailwind as-is is perfectly reasonable. In fact, instead of putting things in variables, the official line is actually that, for large projects, anything with repeated Tailwind styles should be considered for componentization (e.g., <Heading1> instead of <h1 className="...">). Just wanted to throw that out there in case it ends up being right for you down the line.