search

UTDNebula / skedge

MIT License
8 stars 7 forks source link

Replace API request using Trends backend #50

Closed TyHil closed 5 months ago

TyHil commented 7 months ago

Resolves #48, #37, #28

Makes call to nebula API via trends.utdnebula.com/api instead of api.utdnebula.com to conceal API key. Removes API key from config. We should consider removing the API key from the git history with something like git filter-branch --tree-filter "sed -i 's/EM~eW}G<}4qx41fp{H=I]OZ5MF6T:1x{<GF:~v</API_KEY/' src\data\config.ts" --all and a force push Reformats API calls to all go at once instead of one at a time, should speed up Skedge.

A few small things added along the way: Adds titles to define RMP, DIFF, and WTA as Overall Quality, Level of Difficulty, and Would take again. Adds a link to Trends in professor profiles, moves the link to RMP alongside the Trends one at the bottom of the page.

Jake3231 commented 6 months ago

@iamwood Do you think this is worth breaking up into smaller PR's. I think it's probably fine, but is a large change.