UTDNebula / survival-guide

UTD Survival Guide is a guide to being a college student and making the most of your time at UT Dallas and after graduation.
https://guide.utdnebula.com
MIT License
10 stars 0 forks source link

Add matching directory hierarchies for the Components and Style folders #55

Closed AvengingPrime closed 1 year ago

AvengingPrime commented 1 year ago

Closes #54. Added a base for a hierarchical directory structure for the components and style folders. This helps better organise the files for later work, and also mitigates any duplicate component naming issues.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
survival-guide ✅ Ready (Inspect) Visit Preview Feb 8, 2023 at 9:02PM (UTC)
WillieCubed commented 1 year ago

Just wanted to verify: is this ready for review? If not, you can mark it as a draft until you're ready.

image

AvengingPrime commented 1 year ago

Just wanted to verify: is this ready for review? If not, you can mark it as a dra

I think so. For now, I've just added higher level directories. As for sub-directories related to different components (i.e. sub directories for the Sidebar and Content Viewer Components in the Content Viewer Page), they will be added by the respective issue's assignee in the actual issue branch. For example, after this gets merged, I'll add the Content Viewer's sub-directories in the content viewer issue.

WillieCubed commented 1 year ago

I currently only see a single commit with a single new file. If you've created empty directories, they won't show in Git because Git only tracks files. If you would like to go ahead and move the components to use the new directory structure, I would wait until after #40 is merged, merge those changes into this branch, and then refactor from there and leave this as a draft PR until those components are ready.

Additionally, I would keep custom styles (the ones not using Tailwind CSS) in CSS modules that are within a component's subdirectory and refrain from using global styles.

WillieCubed commented 1 year ago

Closing as stale.