UTDNebula / utd-trends

An upgrade to UTD Grades.
https://trends.utdnebula.com
MIT License
18 stars 11 forks source link

Uniform Skeleton for Course and Professor Overview components #171

Open AbhiramTadepalli opened 3 weeks ago

AbhiramTadepalli commented 3 weeks ago

What did you expect to happen?

When loading, since the course number / professor name is already known, it does not "load" in the RHS components.

What happened?

For visual consistency, the course number / professor's loading should be chained to a different ~component~ piece of data that actually loads

Version

Beta 0.1.0

What browsers are you seeing the problem on?

No response

Relevant log output

No response

Code of Conduct

AbhiramTadepalli commented 3 weeks ago

@TyHil Is this a valid request?

AbhiramTadepalli commented 3 weeks ago

How do we handle if the rest of the component doesn't load?

TyHil commented 3 weeks ago

@AbhiramTadepalli what does "chained to a different component that actually loads" mean. I'm not sure what the desired change is for this issue

AbhiramTadepalli commented 3 weeks ago

Intended change: the course number / professor name should appear to load as long as the other data in the component is loading.

Why: so it looks uniform

"chained to a different ~component~ piece of data that actually loads" means: the loading state of the course number / professor name should change when the loading state of a different piece of data in the same component changes.

TyHil commented 2 weeks ago

You can always just make it look like its loading until the rest of the data is ready. I kinda like the way it shows you what's loading tho. Maybe this could be a question for designers.