I got a bunch of warnings from the clang static analyzer, mostly related to implicit type conversions, missing return values, and unused parameters. I think it doesn't hurt to fix them.
Personally I'm not a fan of using std::size_t over int while iterating. I think it's less readable but I can understand how it might cause bugs in extreme cases.
I got a bunch of warnings from the clang static analyzer, mostly related to implicit type conversions, missing return values, and unused parameters. I think it doesn't hurt to fix them.