Too many ids - Githubissues

UTSASRG / Scaler

GNU General Public License v2.0

4 stars 0 forks source link

Too many ids #28

Closed GammaPi closed 2 years ago

GammaPi commented 2 years ago

Currently, libHook contains too many different types of ID, which is error prune,

GammaPi commented 2 years ago

At least, we need to provide documentation for their usages

GammaPi commented 2 years ago

Merge them into a single monolithic array seems to be a good idea. This will also improve cache utilization.

GammaPi commented 2 years ago

Current design is necessary. We could use 3 ids. FileID: id inside executable hookedId: things that is valid timingid: things that is actually invoked

GammaPi commented 2 years ago

Maintain only one id: ScalerID: Symbols that have been confirmed by the user

Other id should be delete when parsed.

GammaPi commented 2 years ago

Completely fixed in libchook.