Open smog-root opened 2 hours ago
🙌 Thank you for bringing this issue to our attention! We appreciate your input and will investigate it as soon as possible.
Feel free to join our community on Discord to discuss more!
thx for pointing out the problems in my code @smog-root buddy, appreciate the efforts
I would like to request a code review and suggestions for enhancements on the following cipher implementations in you'r project:
I'm expecting a gssoc-ext with level label. @UTSAVS26
1. Affine Cipher (affine_cipher.py):
Currently implements encryption and decryption using the Affine cipher.
Potential Improvements:
Validate that the 'a' parameter is coprime with 26.
Consider supporting lowercase characters without losing case sensitivity.
2. Caesar Cipher (caesar_cipher.py):
Potential Improvements:
3. Playfair Cipher (playfair_cipher.py):
Implements Playfair cipher encryption and decryption with key table generation and text preprocessing.
Potential Improvements:
Add error handling for non-alphabetic characters during text preprocessing.
Consider encapsulating the functionality within a class for better organization and state management.