Closed Panda8Bamboo closed 1 week ago
🙌 Thank you for bringing this issue to our attention! We appreciate your input and will investigate it as soon as possible.
Feel free to join our community on Discord to discuss more!
✅ This issue has been closed. Thank you for your contribution! If you have any further questions or issues, feel free to join our community on Discord to discuss more!
Is there an existing issue for this?
What happened?
Description: Currently the def
bidirectional_search
inalgorithms/bidirectional_bfs.py
does not return correct (i.e. shortest)path
fromstart
totarget
. The code itself runs but produces an incorrect result, pointing to an issue in the implementation of the algorithm itself.Steps to Reproduce: Step 1: Navigate to Tests/algorithms/test_bidirectional_bfs.py Step 2: Run
def test_path
Step 3: Notice test fails as expected output (path) does not match actual path.Expected Behavior: The
test_path
test should not fail and the shortest path should be returned.Actual Behavior: The
test_path
test fails as the expected vs actual outputs do not match.Suggestion to fix:
My suggestion is re-implement the code bidirectional search with an earlier version that I wrote (PR: #322 ). The code passed thetest_path
test, returning the shortest path. Since then a new pull request was made ( #431 ) that broke the code.Add ScreenShots
Current
test_path
test behaviour:What browsers are you seeing the problem on?
No response
Record
Full Name
Amber
Participant Role
GSOC