UU-ComputerScience / uhc

136 stars 21 forks source link

Missing support for GHC 8 #71

Closed asr closed 8 years ago

asr commented 8 years ago

Using GHC 8.0.1 RC 2:

$ cabal unpack uhc-light
$ cd uhc-light-1.1.9.2
$ cabal sandbox init
$ cabal install
...
rejecting: hashable-1.2.4.0 (conflict: uhc-light => hashable>=1.1 && <1.2.4)
...
Dependency tree exhaustively searched.

hashable 1.2.4 is required with GHC 8 but it was removed in #69.

atzedijkstra commented 8 years ago

New release 1.1.9.3 has been put on hackage, along with uhc-util-0.1.6.5, along with a version constraint for hashable >= 1.2.4. Not sure whether there is more needed to make it compile/work for ghc 8 as I do not have a ghc8 release available for testing...

asr commented 8 years ago

Not sure whether there is more needed to make it compile/work for ghc 8 as I do not have a ghc8 release available for testing...

I made the test. See https://github.com/UU-ComputerScience/uhc-util/issues/8#issuecomment-186636197.

asr commented 8 years ago

After the fix for https://github.com/UU-ComputerScience/uhc-util/issues/8 there are new problems. From your comment https://github.com/UU-ComputerScience/uhc/issues/73#issuecomment-187059603, I will report these problems as UHC problems.

asr commented 8 years ago

What version of UHC should I use for reporting the issues? The current released version? The master branch? Other branch?

atzedijkstra commented 8 years ago

Reporting an issue against a release or master head version is both fine. If there is a fix or pull request it is preferrable to have this for the master head.

Atze Dijkstra

On 22 feb. 2016, at 13:29, Andrés Sicard-Ramírez notifications@github.com wrote:

What version of UHC should I use for reporting the issues? The current released version? The master branch? Other branch?

— Reply to this email directly or view it on GitHub.

asr commented 8 years ago

Using GHC 8.0.1 RC 2 and master head version (commit aabb6a7):

$ cd EHC
$./configure
$ make
...
[ 23 of 247] Compiling UHC.Compiler.Base.Common ( UHC/Compiler/Base/Common.hs, dist/build/UHC/Compiler/Base/Common.o )

src/ehc/Base/Common.chs:92:1: error:
    Duplicate instance declarations:
      instance Generic Version -- Defined at src/ehc/Base/Common.chs:92:1
      instance [safe] Generic Version -- Defined in ‘Data.Version’
atzedijkstra commented 8 years ago

I have added a check on the compiler version around this code.

asr commented 8 years ago

Thanks. I got the same issue described here when using GHC 8.0.1 RC 2.

asr commented 8 years ago

I got many compilation errors on src/ehc/EHC/BuildFunction/Run.chs. It seems related to a GHC 8.0.1 RC 2 bug (which was fixed in upstream) involving ImpredicativeTypes.

asr commented 8 years ago

How I run the test-suite?

asr commented 8 years ago

I created the PR #76.

asr commented 8 years ago

I got many compilation errors on src/ehc/EHC/BuildFunction/Run.chs. It seems related to a GHC 8.0.1 RC 2 bug (which was fixed in upstream) involving ImpredicativeTypes.

I got the same errors using GHC 8.0.1. Please merge the PR #76.

atzedijkstra commented 8 years ago

I usually run the test suite for variant 100:

make 100/ehc make 100/ehclib make test-regress TEST_VARIANTS=100

This expects that a previous run of the test suite has been done to create the output against which is compared:

make test-expect TEST_VARIANTS=100

Currently the results of such a previous run are not stored in the repo (no need for that currently/until now). Substitute 'uhc' for '100' in case you want to do this for uhc:

make make test-regress TEST_VARIANTS=uhc

On 05 Mar 2016, at 13:52, Andrés Sicard-Ramírez notifications@github.com wrote:

How I run the test-suite?

— Reply to this email directly or view it on GitHub.

asr commented 8 years ago

I had no problems building UHC using GHC 7.10.3 or GHC 8.0.1. I'm running the tests...

asr commented 8 years ago

It seems the tests were ok with both versions of GHC:

$ make test-regress TEST_VARIANTS=uhc
...
== completed with 0 errors, 0 (probably) platform dependent errors, and 149 warnings ==
asr commented 8 years ago

Are you ready for realising to Hackage?

atzedijkstra commented 8 years ago

I am running various build/installation checks now :-).

A

On 21 May 2016, at 07:23, Andrés Sicard-Ramírez notifications@github.com wrote:

Are you ready for realising to Hackage?

— You are receiving this because you modified the open/close state. Reply to this email directly or view it on GitHub

asr commented 8 years ago

Great!

asr commented 8 years ago

I am testing the UHC compiler backend in Agda...

asr commented 8 years ago

I cannot test the UHC compiler backend in Agda because I have no uhc-ligth-1.1.9.4.

atzedijkstra commented 8 years ago

Is uploaded to hackage now. Success :-)!

A

On 21 May 2016, at 07:40, Andrés Sicard-Ramírez notifications@github.com wrote:

I cannot test the UHC compiler backend in Agda because I have no uhc-ligth-1.1.9.4.

— You are receiving this because you modified the open/close state. Reply to this email directly or view it on GitHub

asr commented 8 years ago

Yep!