search

UU-ComputerScience / uuagc

3 stars 9 forks source link

Expand tabs and make compiling with -DEXTERNAL_UUAGC work #5

Closed noughtmare closed 3 years ago

noughtmare commented 3 years ago

I think the -DEXTERNAL_UUAGC flag is necessary if you want to make changes to any of the .ag files (which I plan to do).

The expansion of tabs (to 8 spaces) is better for portability, because some systems choose a different tab width (such as here on GitHub).

EDIT: I have now also fixed some errors that occur when building with the with-loag flag. Some types got inferred too generally which would require FlexibleContexts, but I simply added the explicit concrete type signature. And one function got renamed.

noughtmare commented 3 years ago

@jbransen have you seen this?

jbransen commented 3 years ago

Thank you for the effort! I must say I am not such a fan of the whitespace changes, it is fine to define the tabwidth to be 8, that's what Haskell does as well, and this MR would conflict a lot with all other open branches, but given that there is no other development that's not a problem :-)