search

UU-Hydro / PCR-GLOBWB_model

PCR-GLOBWB (PCRaster Global Water Balance) is a large-scale hydrological model intended for global to regional studies and developed at the Department of Physical Geography, Utrecht University (Netherlands). Contact: Edwin Sutanudjaja (E.H.Sutanudjaja@uu.nl).
GNU General Public License v3.0
116 stars 79 forks source link

Add support for python 3 #7

Closed mcflugen closed 5 years ago

mcflugen commented 5 years ago

This pull request allows PCR-GLOBWB to work with both Python 2 and Python 3. I've used the six package to do this and so six is now an additional requirement (but one that's well supported and easily installed). A better solution would be to make this PCR-GLOBWB Python 3-only since Python 2 will soon no longer be supported.

Python 3 support was necessary for me so that I can incorporate PCR-GLOBWB into the pymt.

edwinkost commented 5 years ago

Dear Eric @mcflugen, many thanks for all of these. I am currently on holidays (until 1 July) and I'll check and incorporate your changes (after I return from holidays).

Before my holidays, I also have started some changes to support Python 3 as the new version of PCRaster (>= 4.2) works with Python 3 only. Yet, this development is far from finish, so your pull request is very valuable. Unfortunately, we also still have to support Python 2 as most of our users still use PCRaster 4.1 (< 4.2) that can work with Python 2 only.

Many thanks once again. Best, Edwin

edwinkost commented 5 years ago

I will try to merge and check this.