UU-Hydro / PCR-GLOBWB_model

PCR-GLOBWB (PCRaster Global Water Balance) is a large-scale hydrological model intended for global to regional studies and developed at the Department of Physical Geography, Utrecht University (Netherlands). Contact: Edwin Sutanudjaja (E.H.Sutanudjaja@uu.nl).
GNU General Public License v3.0
116 stars 79 forks source link

Error when running with dynamicFloodPlain turned off #8

Closed mcflugen closed 5 years ago

mcflugen commented 5 years ago

With the most recent changes on the develop branch, I get an error when trying to run PCR-GLOBWB with dynamicFloodPlain set to False (I'm using the Rhine-Meuse config file in grpc4bmi-examples repository). The error I get when running the deterministic_runner.py script is the following,

Traceback (most recent call last):
...
AttributeError: 'Routing' object has no attribute 'channelStorageCapacity'

As far as I can tell, the fix is simply to wrap the flood-plain specific code in something like: if self.floodPlain - at least that seems to work for my case. I will send a pull request with my fixes to see what you all think.